Deprecate functions: surrival --> survival
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
commented
Dec 11, 2024
|
I hereby apologize for my poor English skills.... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 21.33% 21.33%
=======================================
Files 36 36
Lines 3305 3305
=======================================
Hits 705 705
Misses 2600 2600 ☔ View full report in Codecov by Sentry. |
theHenks
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Perfect, thanks @fhagemann .
We should do the same in legend-julia-dataflow, so maybe let's at least open an issue there.
|
Don't worry. Now, that a lot of changes made it onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's remove a legacy typo that has been used in quite some places in
LegendSpecFits:some methods were named
surrivalinstead ofsurvival. This PR deprecates the method withsurrivalin their name and renames them tosurvival.Calling the old methods should still work (and the functions are still exported), but they should be removed with the next breaking release.